Dear Andrey,
Thanks for the fix. We did have our "own" jQuery at times, so who knows just
how I got confused.
Your instructions commit is dated June 12, 2016. "git blame" says the last time
I touched this code was committed June 13, 2016. Did not look too hard to see
if that is a coincidence or accident. I think it is cosmetic. ;-)
https://github.com/PreTeXtBook/pretext/commit/429861fd2297bb303c75ad89115ab6a87cd2ecad
We'll get this fixed up so "new" pages will be right.
Rob
On 3/4/22 10:32, Andrey Novoseltsev wrote:
The issue is currently fixed by rolling back to
https://github.com/sagemath/sagecell/commit/e382c614a287364c62343079ea295daf80b1d761
which was the last change necessary to work with Sage 9.5.
Fixing it is very easy - just do not wrap the calls with $(...). However, it is
a fix that has to be applied to every page that followed mixed instructions. For
the record, "new" instructions were posted in 2016:
https://github.com/sagemath/sagecell/commit/035be7f050e550a9c66a75f3ad522e446ab2b1f2
Given that people still use old embedding, I don't think that there is any
reasonable "deprecation period" that would work, we should just keep it forever
for backward compatibility.
On Friday, 4 March 2022 at 09:47:38 UTC-7 far...@aimath.org wrote:
Is there some way that other JavaScript on that page
(meaning, JS that I control) can do something to allow that page
to work with the new setup on the server?
That way you could switch now and do not need to worry about
old pages breaking.
On Fri, 4 Mar 2022, Rob Beezer wrote:
> A reversion would be very helpful. We can implement a correct procedure
and ask publishers to rebuild before September 30. Would that work on your
end?
>
> Thanks for your prompt attention to this one!
>
> Rob
>
> On March 4, 2022 8:26:04 AM PST, Andrey Novoseltsev <novo...@gmail.com>
wrote:
>> The old instructions were:
>>
>> load jQuery
>> load embedded_sagecell
>> use $(makeSagecell)
>>
>> Then they changed to
>>
>> load embedded_sagecell
>> use makeSagecell
>>
>> while the page David linked is using a combo
>>
>> load embedded_sagecell
>> use $(makeSagecell)
>>
>> which kind of does not make sense, but continued to function. I will
revert
>> to it shortly for the time-being, do we want to keep it forever?
>>
>
> --
> You received this message because you are subscribed to the Google Groups
"sage-cell" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to sage-cell+...@googlegroups.com.
> To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-cell/MTAwMDAzNy5iZWV6ZXI.1646411796%40quikprotect
<https://groups.google.com/d/msgid/sage-cell/MTAwMDAzNy5iZWV6ZXI.1646411796%40quikprotect>.
>
--
You received this message because you are subscribed to the Google Groups
"sage-cell" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-cell+unsubscr...@googlegroups.com
<mailto:sage-cell+unsubscr...@googlegroups.com>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-cell/33e375d4-72c3-44a2-9205-b1a1fac6ba85n%40googlegroups.com
<https://groups.google.com/d/msgid/sage-cell/33e375d4-72c3-44a2-9205-b1a1fac6ba85n%40googlegroups.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"sage-cell" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-cell+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-cell/d17828d0-d994-28b2-39f2-e4fa4aef5967%40ups.edu.
