Salut,

I forward Nicolas' post on the trac, so it is easier to answer:

Hi Christian!

Thanks for this useful feature!

A couple suggestions:

Thanks for being careful with potential conflicts with #6588 (so far
so good :-))
I would prefer to call the method as RootSystem?(["A",
3]).root_lattice().root_poset() (possibly with a shortcut from root
system, to possibly let the user choose in which realization the roots
are returned
The code could be written generically for any RootLatticeRealization?
by computing scalar products with coweights.
Even without using scalar products, there should be no need to use
dict's. Better use instead something like:
   for (i,c) in alpha:
       if beta[i] < c: ...
The root comparison function could be extracted as a separate method,
as it could be of more general use
Cheers,

Nicolas

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.

Reply via email to