Le mercredi 27 avril 2011 à 20:24 +0200, Florent Hivert a écrit : > Hi there, > > I've a rejection both in sage-4.7-alpha5 and sage-4.7rc0: > > application de sl2z_decomposition-vd.patch > patching file sage/modular/arithgroup/arithgroup_perm.py ... > 5 out of 10 hunks FAILED -- saving rejects to file > sage/modular/arithgroup/arithgroup_perm.py.rej > l'application du patch a échoué, impossible de continuer (essayez avec -v) > patch failed, rejects left in working dir > des erreurs se sont produites durant l'application, veuillez corriger puis > rafraîchir sl2z_decomposition-vd.patch > > Vincent, can you investigate it ?
Oups!!! It is probably my fault. I created the patch : trac_11257_avoid_coercion_power_zero-nb.patch I put it very early in the queue, hopping this critical relatively small patch could go in sage in a short time. As SL2Z didn't have a one() method, I just had it in my patch. I am a little afraid because my patch is not final and I will probably modify it in the days to come. Anyway, #11257 is a kind of patch which have influences to half of the objects in Sage (a modification on generic_power of sage.structure.element). I also don't have a strong experience on patching basic structure. So, for these reasons, I would say propose two solutions: 1 - If sl2z_decomposition-vd.patch is not crucial for your current research Vincent (or you don't intend to use it the days to come), we can guard it until #11257 is final and I will try to deal with the ticket as fast as I can. I don't want to give warranties I can't stand but if some war veterans have time to check, give advises and review the patch, it can be done in 2 or 3 days... It is one of my priority with week. 2 - I will work on a separate branch, and you should rebase your patch if #11257 go in sage before your work... The point is just avoid rebase to each push. It is up to you. Cheers, Nicolas (the little). -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
