On Thu, Aug 25, 2011 at 11:12:13PM -0700, Anne Schilling wrote:
> (Could Mike and I be both authors and reviewers at the same time?)
The design looks good. If any line of the code has been at least
written by one and reviewed by the others, this sounds good.
Florent: would you suggest to use listclone rather than
CombinatorialObject?
Quick comments:
- in the doctests of the two __init__:
- Use TestSuite(c).run() rather than the loads/dumps thingy
- add:
sage: c
[2, 1]
sage: type(c)
...
- from_partition: specify one way or the other that this is the
trivial bijection. Maybe add a link to :meth:`to_partition`
- to_partition: the cache shouldn't do much of a difference
- to_bounded partition, to_grassmannian, ...: the doctests should
each start with a one line summary. Something like:
``bijection to k-bounded partitions``
- to_grassmanian: add a doctest such as ``sage: c.parent()``
- Cores: use the category FiniteEnumeratedSets(). Since list is
implemented, this should be sufficient.
Thanks for your work!
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
