Hi all, since Nathann started to "hate" combinatorial map decorators, I think we can start yet another discussion if we want them or not here on the mailing list.
I start with Nathann's comment on #14734: """ The function's name is way too vague, and I think that it brings absolutely nothing to Sage. It is just there to add an output to find_stat, and has nothing to do in Sage. I hate this patch. Oh, and just to keep on being unpleasant : from time to time I write long graph functions that I move to modules, and never import them to Graph or DiGraph? class. I do that because we already have a lot of methods in those objects, and that they would not be useful to the vast majority of Sage users, only to specialists. So I store them where they will only be found by those who look for them. If at the same time you add empty functions just to add maps to a third-party project, I do feel like I waste my time when I do that. But that was just to keep on being unpleasant. Nathann """ And my answer: """ I do not agree that the combinatorial_map decorator doesn't have anything to do with Sage. It organizes mathematical concepts by providing the possibility to ask for things like: - which involutions are there on permutations - which bijections between 132-avoiding permutations and Dyck paths are there, and so on. The decorator should even be able to carry information about the maps (though this is not yet there), like "injective", "surjective", "bijective", ... And these mathematical information are interesting and useful for Sage users! Feel free to start a discussion about the decorators on the sage-combinat mailing list, or to ask for a poll if the community wants such decorators or not. I will at least copy your comment and my answer there in order to get a discussion started. Obviously, the decorator might have downsides. E.g., we have seen that it not yet works well together with the cached_method decorator. I will add some further points once we have a discussion started at sage-combinat-devel. Cheers, Christian """ What do others think about decorating maps between combinatorial objects by a decorator? -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-combinat-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-combinat-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-combinat-devel. For more options, visit https://groups.google.com/groups/opt_out.
