Hey Florent, I'm very sensible to the namespace pollution question. However, as a user > (contrary to a developper) I'm using from time to time those methods > directly > and I'm considering those as part of the public API. Indeed, its not > uncommon > that calling one_on_basis or product_on_basis save you some time. And > since I > value more consistency than small namespace, I'm in favor of having all > on_basis methods public. >
IMO, they should all be pulled from the namespace (but included in the documentation; although I suspect anyone who is optimizing will quickly encounter these functions, private or public, by going through the code). Yet that takes more time/effort to do than I have to devote to that right now. Another reason why I think it should be private is that if the user wants to override directly on the elements is_even_odd, then you don't want to have such a method even available (although in a way, that is a subissue of the namespace pollution). So I feel the *_on_basis methods are more of an implementation detail than public API. Best, Travis -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-combinat-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-combinat-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-combinat-devel. For more options, visit https://groups.google.com/d/optout.
