Here's some comments. (Sorry for taking all the low-hanging fruit...) - Robert
On Nov 17, 2007, at 10:03 PM, mabshoff wrote: > Ok, various people have gone over track and commented on tickets. > > But the following patches need reviews: > > #1107 Minkowski bound...I heard about that somewhere recently :). The patch is good. > #1120 Works great for me. Very nice. > #1130 This seems to rely on an earlier patch. (#1120?) See comments on trac. > #1131 Looks good to me. > #1134 Should be applied, but issue not closed. > #1148 Nice patch. I added generic valuation back in as a fallback. > #1156 Should definitely go in as is, but I haven't verified that there aren't more missing functions so the ticket shouldn't be closed until someone does. > #1174 Looks good, but there should be a doctest. > #1186 Patch did not resolve the correct issue (see comment). > #1194 Works great for me. --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
