Anyone should be able to be a reviewer, but not everyone a PR-approving reviewer.
The problem is that approving a PR is something that should not be left to arbitrary people. I.e. not every reviewer, potentially requesting changes and approving changes, should be able to approve the PR. So the label change can be automated, but not any "approval" should trigger it. On Wed, 5 Apr 2023, 09:39 Kwankyu Lee, <ekwan...@gmail.com> wrote: > (6) What to do with automatic labelling vs manual labelling? > https://github.com/sagemath/sage/pull/35172 > > > If any organization member can be a reviewer, automatic labelling should > be implemented, since only triage team members can add labels. But I think > the current manual labelling should not be hindered by the automating > script. > > > > > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/9eedde50-afca-4224-9728-e07ece238a40n%40googlegroups.com > <https://groups.google.com/d/msgid/sage-devel/9eedde50-afca-4224-9728-e07ece238a40n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq3pZLYJ5s9xFTYFOYvNpouF%2BS8wCA_dTbs5LTs-sTEjkg%40mail.gmail.com.
