On Fri, May 26, 2023 at 06:34:25AM -0700, Matthias Koeppe wrote:
> Thanks, Tobias, for opening this vote thread. Here on sage-devel, this is a 
> much better setting than what you attempted 
> in https://github.com/sagemath/sage/pull/35404#issuecomment-1504474945
> 
> I am voting NO.
> 
> There's a simple rationale: 
> 
> I. This proposed policy change does not solve any problem. There are no 
> problems whatsoever with how we have managed the support of Python versions 
> since 2020 (when it became possible to use system Python instead of only 
> the Python from our SPKG.) 
this is not true. It solves a range of problems, e.g., in no particular
order:
1) lack of hands to support all that obsolete versions, 
2) blocking new Python features in 3.9 from being used in Sage
3) falling behind w.r.t. versions of various Python packages used in Sage,
packages which are already merging 3.8-incompatible code, e.g. networkx,
scipy, etc.
4) keeping special backported to Python 3.8 packages (at least one such
package exists) 
> 
> II. The proposed policy change creates new problems. Following this policy 
> would force us to drop support for a particular Python version at times 
> when it would be harmful for our project. Specifically, right now it would 
> *force* us to drop support for Python 3.8 and hence for using the default 
> Python on Ubuntu Linux 20.04 (an LTS release, with "End of Standard 
> Support" April 2025 and "End Of Life" April 2030. It is the very point of 
> LTS releases to provide a stable software environment;


No, this is not a problem, as Ubuntu Linux 20.04 provides a Python 3.9
system package, which can be installed and used if desired.
(And there are other options, e.g. pyenv, conda, etc)
And we have a long story of supporting Linux distros with system Python
being much older than the one needed by Sage.
It's also not clear what you propose in this respect - support Python
3.8 until Ubuntu 20.04 reaches EOL (which is much longer than Python's
3.8. EOL).

> so, yes, Python 3.8 
> is fully supported, and if Python 3.8.x had bugs relevant for Sage, we 
> would know about it because we are testing. 

Python 3.8 is not "fully supported". It's on life support, only
receiving security-related fixes, but no other fixes.
The only fully supported Python is 3.11, which does get bug fixes
for all the bugs found.

> 
> III. Our existing practice is to carefully consider and weigh various 
> factors that are relevant for the Sage project, rather than following a 
> fixed schedule that is set by an external, largely separate community. I 
> briefly explained what we do in 
> https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/x3qOdPB5BQAJ; but 
> I'll expand here on some important factors:
> 
> a) Sage has a dual role as a library ("project") and as a distribution. NEP 
> 29 was designed for projects, and not for software distributions.

No, Sage is just a project, with lots of dependencies (way too many).
It's not a software distribution in any way, it does not include
essential tools to build it (e.g. no C/C++ compiler on macos).

> 
> b) In Sage, we only have one line of releases. Hence users who want any bug 
> fixes need to use our latest version. In contrast, just like Python itself, 
no, Sage is more like Python - you don't get the bug fixed in Python 3.10 or
older!

> many other projects have at least two separate branches: A branch on which 
> the cutting edge development takes place (new features etc.), and a branch 
> from which maintenance updates are made. For example, NumPy removed support 
> of Python 3.8 in their development branch earlier this year; but this in 
> preparation for the 1.25 release expected this summer.
Do you propose to fall behind Numpy?
Dropping Python 3.8 now will let us to be ready to upgrade our Numpy.

> NumPy continued to 
> make maintenance releases on the 1.24 branch 
> (https://github.com/numpy/numpy/releases), and by policy, these maintenance 
> upgrades never drop the support of a previously supported version.
> 
> c) NEP29 was designed for and is in use by a part of the scientific Python 
> community, to address the need to be able to use features of new Python 
> versions and features of NumPy/SciPy faster. This is important for many 
> projects that have NumPy/SciPy as their dependencies. 
> 
> d) In contrast, our uses of NumPy/SciPy in the Sage library are very basic 
> and dating back by about a decade;
No, not true. E.g.

schemes/riemann_surfaces/riemann_surface.py is neither "basic" nor
dating back that much - it's also  under relatively active development, see its 
header:

- Alexandre Zotine, Nils Bruin (2017-06-10): initial version
- Nils Bruin, Jeroen Sijsling (2018-01-05): algebraization, isomorphisms
- Linden Disney-Hogg, Nils Bruin (2021-06-23): efficient integration
- Linden Disney-Hogg, Nils Bruin (2022-09-07): Abel-Jacobi map

It's using Voronoi diagrams from scipy.


> with the exception of the optional use 
> of a recent SciPy feature (the high-performance optimization solver HiGHS, 
> see 
> https://github.com/sagemath/sage/wiki/Sage-10.0-Release-Tour#linear-programming-and-extensions),
>  
> which motivated our quick upgrade to the current SciPy version in Sage. And 
> as another example, also our use of matplotlib in the library dates back by 
> a decade or more; we regularly have to update when new matplotlib versions 
> come out that make API changes, but we haven't picked up any new features 
> in a very long time.
> 
> e) Yes, synchronization between projects matters for maintainability. But 
> Sage is downstream of lots of Python packages; before we can offer support 
> for a new version of Python, we often have to wait until all or most of our 
> dependencies provide support for that new version. For example, some 
> projects are actively working on support for the Python 3.12 release 
> expected this early Fall; but for us, this is not actionable because we 
> have to wait for critical dependencies;

I don't see how this is relevant - it's actually beneficial to limit the
old versions of Python supported in Sage, as we don't want to get
blocked by any package which stops supporting Python 3.8. As everything
we use supports Python 3.9+, we don't need Python 3.8 already now.
Once again, it's not about picking up new features, it's about dropping
old ones, which is a completely different story.

> see https://github.com/sagemath/sage/issues/34788 . Likewise, it is not 
> useful for us to drop support for an old version before there is a clear 
> benefit for us, brought for example by important upgrades that have dropped 
> support already.

So far you failed to list any benefits.

> 
> 
> (As suggested by Tobias, any discussion of my explanations above is best 
> sent to 
> the https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/2sTiwdKPBQAJ 
> thread.)

sorry, it will get lost there, so I'm replying here instead.

Dima

> 
> 
> On Friday, May 26, 2023 at 3:12:16 AM UTC-7 Tobias Diez wrote:
> 
> > Dear Sage developers,
> >
> > the NumPy enhancement proposal 29: "Recommend Python and Numpy version 
> > support as a community policy standard" (available at 
> > https://numpy.org/neps/nep-0029-deprecation_policy.html) specifies when 
> > it's okay to drop support for old Python version. 
> >
> > Namely, a release should support "all minor versions of Python released 42 
> > months prior to the project, and at minimum the two latest minor versions. 
> > ". In particular, this means:
> > - Currently, Sage should support > 3.8.
> > - On Apr 05, 2024 we should drop support for Python 3.9 (initially 
> > released on Oct 05, 2020)
> >
> > Based on previous discussions on this topic (
> > https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/2sTiwdKPBQAJ, 
> > https://github.com/sagemath/sage/issues/30384, 
> > https://github.com/sagemath/sage/pull/35403), I'm calling for a vote on 
> > adapting the Python version support of NEP 29 in Sage. Voting ends at the 
> > 7th June,  AoE. Please use this thread only for sending votes, to make it 
> > easier to count them afterward; and use the thread 
> > https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/2sTiwdKPBQAJ for 
> > discussion.
> >
> > *Summary *of the points brought forward in the discussions linked above
> > 1. The current practice in Sage is to evaluate whether to increase the 
> > minimum version of Python supported at the beginning of each release cycle. 
> > With regard to such a practice, the NEP 29 documents remarks "As there is 
> > no objective threshold to when the minimum version should be dropped, it is 
> > easy for these version support discussions to devolve into bike shedding 
> > <https://en.wikipedia.org/wiki/Wikipedia:Avoid_Parkinson%27s_bicycle-shed_effect>
> >  
> > and acrimony." Sadly, an example of this can be found in the current 
> > discussion of dropping Python 3.8 support in 
> > https://github.com/sagemath/sage/pull/35404 with emotions running so high 
> > that sage-abuse had to step in. Adopting a version policy would prevent 
> > such discussions. On the other hand, by following a given policy, we would 
> > loose some flexibility.
> > 2. The main idea of NEP 29 is to have a community-wide standard. It is 
> > followed by many scientific packages such as Scipy, Matplotlib, IPython, 
> > Jupyter, Pandas, scikit, astropy, cuda, cirq, jax, pytorch among others. 
> > The 
> > adoption of NEP 29 will harmonize Sage's deprecation policy with these 
> > other major libraries. 
> > 3. The NEP 29 drop schedule is much faster than the EOL schedule of Python 
> > itself. Python 3.8 is supported until 2024-10, but NEP 29 already drops it 
> > 2023-04. However, adhering to the EOL schedule would prevent us to updating 
> > these packages that follow NEP 29.
> > 4. The NEP 29 schedule is about one release cycle faster than the 
> > previous drops (e.g. Python 3.7 support was dropped in Sage 9.7 while 
> > according to NEP 29 it would have been Sage 9.6).
> > 5. The faster drop schedule will free developer resources (less systems to 
> > test) and potentially increase developer productivity as it allows us to 
> > use newer language features.
> > 6. The faster drop schedule might be inconvenient for users who rely on 
> > older Python versions. To some extend this is remedied by our python 
> > install package, and relatively straightforward upgrade paths on most 
> > system. One should also note that users relying on other scientific python 
> > packages are likely forced to upgrade anyway, since these other packages 
> > likely follow NEP 29.
> > 7. The faster drop schedule would force users to upgrade to newer Python 
> > versions and thereby profit from fewer bugs and security issues. It is 
> > however questionable if Sage should play this educator role.
> > 8. One of the main goals of NEP 29 is to improve downstream project 
> > planning by having a community-wide standard. This is currently not very 
> > relevant for us as Sage is currently upstream of nothing except for some 
> > user packages. With the modularization effort, this may change in the 
> > future.
> > 9. There are not many other documented policies. As said above, most 
> > scientific python projects follow NEP 29. Most projects in web development 
> > (e.g flask) seem to drop a version once it reaches EOL. Machine learning 
> > projects follow a similar EOL policy (e.g. tensorflow) or roughly follow 
> > NEP 29 (scikit-learn). Some end-user applications have even stricter 
> > version constraints then NEP 29 (e.g. home-assistant only supports the two 
> > latest minor releases).
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/f6bf61cd-373f-4829-bfba-392ce32daeban%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ZHDI6az0t%2BuI9Iqk%40hilbert.

Attachment: signature.asc
Description: PGP signature

Reply via email to