On Saturday, November 25, 2023 at 1:24:42 AM UTC-8 Kwankyu Lee wrote: (2) How do we count approvers and disapprovers for a disputed PR: A reviewer becomes an approver (who is in favor of the PR) when he/she sets "Approve" in the github review system. A reviewer becomes a disapprover (who objects the PR) when he/she sets "Request changes" in the github review system.
I think there needs to be a clear indication that a voting period is active (and when it closes). Perhaps we can use a PR label "s: voting" or "s: needs votes"? -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/2d6d6612-41b7-4569-a8ea-3cd08e411b33n%40googlegroups.com.
