+1 for the one-line change of the type from "optional" to "standard". -1 on everything ("standard pip" or "standard wheel") that involves an unnecessary version constraint and an explicit declaration of the runtime dependencies.
On Saturday, February 17, 2024 at 4:51:45 PM UTC+8 Dima Pasechnik wrote: > I have made it clear under what condition you can count my vote as +1. > > To make it clear: it is -1 if the condition is not met. > > > On 17 February 2024 04:26:14 GMT, Matthias Koeppe <matthia...@gmail.com> > wrote: > >> Note that posting a proposal here on sage-devel to make the packages >> standard followed the policies of our project. >> "optional packages stay in that status for at least a year, after which >> they can be proposed to be included as standard packages in Sage. For this >> a GitHub PR is opened with the label c: packages: standard. Then make a >> proposal in the Google Group sage-devel." >> https://doc.sagemath.org/html/en/developer/packaging.html#inclusion-procedure-for-new-and-updated-packages >> >> Multicasting "negative reviews" to tickets is not part of the procedures >> of our project; cf. >> https://github.com/sagemath/sage/pull/36726#issuecomment-1820148873 on >> the emergence of this idea. >> >> On Friday, February 16, 2024 at 4:34:12 PM UTC-8 Dima Pasechnik wrote: >> >>> >>> >>> On 16 February 2024 23:33:48 GMT, Matthias Koeppe <matthia...@gmail.com> >>> wrote: >>> >On Friday, February 16, 2024 at 1:25:13 PM UTC-8 Dima Pasechnik wrote: >>> > >>> >>On Friday, February 16, 2024 at 9:38:16 AM UTC-8 Dima Pasechnik wrote: >>> >My vote for is conditional on them remaining pip packages, and that's >>> not >>> >what your PRs do. >>> > >>> > >>> >I'll count that as 0. >>> >>> you can count that as negative reviews on your PRs >>> as they are now. >>> >>> >>> > >>> >> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/265a2a83-5d12-4f4b-b243-f207744aa6b0n%40googlegroups.com.