+1 On Monday, March 4, 2024 at 1:57:48 PM UTC Dima Pasechnik wrote:
> +1 > > On Mon, Mar 4, 2024 at 8:43 AM David Roe <roed...@gmail.com> wrote: > >> The following proposal has been made several times the last few weeks: in >> PR #37428 <https://github.com/sagemath/sage/issues/37428>, in this thread >> <https://groups.google.com/g/sage-devel/c/uWHaWK7b6H4> and then in this >> thread <https://groups.google.com/g/sage-devel/c/XDvKkMRoDk4>. It is >> orthogonal to the ongoing vote in this thread >> <https://groups.google.com/g/sage-devel/c/E0qfJTMETDk>. With no further >> discussion, I'm calling a vote. >> >> *Background* >> >> Starting in Sage 10.2, PRs with the Blocker label have been merged into >> all other PRs before running CI; see the changelog >> <https://github.com/sagemath/sage/wiki/Sage-10.2-Release-Tour#open-blocker-prs-are-applied-automatically-in-ci-workflows> >> >> and this post >> <https://groups.google.com/g/sage-devel/c/uWHaWK7b6H4/m/cM77D8E5AAAJ> >> for more details. This has led to disagreements about whether this label >> should be applied. >> >> *Proposal* >> We use "CI Fix" rather than Blocker to determine whether an open PR >> should be merged before running CI. Blocker will retain its previous >> meaning of a PR that should be merged before the next release is finished. >> The process below describes how to resolve disagreements about whether the >> "CI Fix" label should be applied. >> a. Only PRs with positive review should be marked with the "CI Fix" >> label. This should be done if both author and reviewer agree that it is >> appropriate, and a rationale should be given in a comment on the ticket. >> b. If a PR becomes disputed (as described in this proposal >> <https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ>), the "CI Fix" >> status can be voted on separately upon request; otherwise it should be >> applied if and only if positive review is applied. >> >> Voting will be open until Wednesday, March 13. >> David >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/77cc05b2-1c52-4aae-80ca-4d0ec0830e2dn%40googlegroups.com.
