*> (Note that only members of the Triage team can set the "needs review" label.)*
See this comment in #35927 <https://github.com/sagemath/sage/issues/35927#issuecomment-2152993322> for a suggestion to solve this. Matthias Koeppe schrieb am Dienstag, 28. Mai 2024 um 21:35:26 UTC+2: > I'll expand a little bit, in the hope to stimulate a constructive > discussion. (A previous related thread: > https://groups.google.com/g/sage-devel/c/sulCa-6EZRA/m/86jFAw9NAAAJ) > > There is a very serious, project-level concern: Is our project welcoming > to new contributors? > We tell contributors to get started by preparing small simple PRs; but are > these PRs getting reviewed and merged? > > We currently have 177 open, non-draft, non-"positive review", non-"needs > work", non-"needs info" pull requests. > > https://github.com/sagemath/sage/pulls?q=is%3Aopen+is%3Apr+-label%3A%22s%3A+positive+review%22+-label%3A%22s%3A+needs+work%22+-label%3A%22s%3A+needs+info%22+draft%3Afalse > (Note that only members of the Triage team can set the "needs review" > label.) > > What can we do to make sure that PRs get reviews? > I frequently set component labels ("c: ...") on other people's unlabeled > Issues and PRs. Does this help at all? > What labels would help people discover PRs that they would be able to > review? > > Matthias > > On Friday, May 10, 2024 at 7:02:19 AM UTC-7 Matthias Koeppe wrote: > > FWIW, I suggested to implement this feature in > https://github.com/sagemath/sage/issues/37254; I'm thankful to Aman Moon > for implementing this feature and Sebastian Oehms for his help with it. > > Obviously a metric such as the number of lines of changes is only a > one-dimensional way to express the complexity of a PR. > When I suggested the feature, I explained the possible positive effects: > - A size label "tiny" could encourage quick reviews of trivial changes. > - A size label "huge" could help flag problematic PRs. > Personally I think that the size labels for "medium-sized" PRs do not add > much and could be removed. > > But I'll note that "developer experience" improvements like this one are > really best developed exactly as it was done here: By deploying them early, > the developer community can gain concrete experience with them -- and then > suggest and implement refinements based on the experience. Harsh dismissals > of the whole features, on the other hand, are not very helpful. > > Matthias > > On Thursday, May 9, 2024 at 2:46:17 PM UTC-7 Travis Scrimshaw wrote: > > I am *very* strongly opposed to these tags. Their cutoffs are arbitrary > nor they serve no useful purpose as far as I can tell. To this point, they > do not reflect the difficulty of a review; in fact, they are at best > counterproductive to finding reviewers because it might deter people from > reviewing "large" or "huge" changes as they can include lots of trivial > doctest changes. At best it is just additional clutter in all of the > information for PRs. > > From a community perspective, I feel such changes should have been brought > to the attention of sage-devel once the PR was at a positive review. > Specifically, *before* the PR was merged. Not everyone has time to read > every PR, and a small consensus of developers might not reflect the > development community at-large when making changes like this. > > Best, > Travis > > > On Tuesday, May 7, 2024 at 3:12:27 PM UTC+9 seb....@gmail.com wrote: > > Dear Sage developers, > > You may have noticed that since yesterday a new type of labels with the > `v:` prefix has appeared on our PRs. These are automatically set to > classify PRs based on their size. For more information, see #37262 > <https://github.com/sagemath/sage/pull/37262>. > > Sebastian > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/72772128-4ced-4e00-9ac6-7993bf7fa6f3n%40googlegroups.com.
