Hi,

Hopefully, some of you may have noticed that the latest release 10.8.beta2 
did not appear at

https://github.com/sagemath/sage/releases

These releases are important for properly documenting your contributions.

The github workflow ".github/workflows/dist.yml" is responsible for 
automatic creation of the releases.

I traced how it stopped working. The PR merged to 10.8.beta2

https://github.com/sagemath/sage/pull/40709

is the culprit. It removed a significant portion of the workflow script. In 
particular, the workflow step "Create release".

I am upset by that the PR author removed the code in the name of "outdated 
things". We have to understand the code and why it exists before we declare 
that the code is  "outdated". 

I am upset by that the PR reviewer gave the PR positive review without 
"reviewing". A reviewer should be half the author. A reviewer should be 
especially careful when a PR removes code instead of adding code, since 
that is likely to break things. 

Please restore the carelessly removed code.



-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/sage-devel/6d6951d2-861a-4ce7-9fd1-c1e362fbeeden%40googlegroups.com.

Reply via email to