Hello sage-devel, I feel a bit guilty asking this after having assigned reviews to people (the response has been great btw, thanks!), but I realise that my Sage development education has a significant flaw: I don't know the proper way to review an spkg.
There is good documentation in the developer guide for (a) creating an spkg and (b) reviewing patches in trac. However, I couldn't find anything about reviewing spkg's, and some things are rather different from just patches. For instance, does one have to build the spkg on all platforms supported by Sage? Should one check that spkg-install and SPKG.txt conform to the recommendations for making an spkg? Is the procedure for experimental/optional spkg's different than the one for standard spkg's? What I am looking for is a step-by-step description that would guide me through that process of reviewing, so that I don't give a positive review to something that will create a Sage botnet :) Does such a document exist? If not, can the accumulated wisdom of sage-devel put one together? Best, Alex -- Alex Ghitza -- Lecturer in Mathematics -- The University of Melbourne -- Australia -- http://www.ms.unimelb.edu.au/~aghitza/ --~--~---------~--~----~------------~-------~--~----~ To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
