I think your suggestion makes sense at least in the short term.  I
admit my own frustration with the current plotting code means I tend
to write my own functions to extract and plot the vertices, edges, and
faces so I've been lazy about fixing things.

-Marshall

On Sep 10, 5:49 pm, davidp <davide...@gmail.com> wrote:
> Lines 1483 and 1484 in polyhedra.py are
>
>         projection.render_vertices_3d(width=3, color='green', **kwds) +
> \
>         projection.render_wireframe_3d(width=3, color='green', **kwds)
> + \
>
> Setting the color and width here prevents the user from doing this at
> the command line (see example below).  I would suggest replacing the
> lines with
>
>         projection.render_vertices_3d(**kwds) +\
>         projection.render_wireframe_3d(**kwds) + \
>
> If there is a good reason to want the default to be width=3 and
> color='green', then kwds should be tested first before setting these
> defaults, I guess.  I would be happy to submit a patch, but I am not
> sure what is intended.
>
> --Dave
>
> sage: p = polytopes.n_cube(3)
> sage: p.show()
> sage: p.show(color='red')
> ---------------------------------------------------------------------------
> TypeError                                 Traceback (most recent call
> last)
>
> /usr/local/sage-4.7/devel/<ipython console> in <module>()
>
> /usr/local/sage-4.7/local/lib/python2.6/site-packages/sage/geometry/
> polyhedra.py in plot(self, **kwds)
>    1998             render =
> Polyhedron._render_method[self.ambient_dim()]
>    1999             if render != None:
> -> 2000                 return render(self,**kwds)
>    2001         raise NotImplementedError('Plotting of
> '+str(self.ambient_dim())+
>    2002                                   '-dimensional polyhedra not
> implemented')
>
> /usr/local/sage-4.7/local/lib/python2.6/site-packages/sage/geometry/
> polyhedra.py in render_3d(projection, **kwds)
>    1482     return \
>    1483         projection.render_vertices_3d(width=3, color='green',
> **kwds) +\
> -> 1484         projection.render_wireframe_3d(width=3, color='green',
> **kwds) + \
>    1485         projection.render_solid_3d(**kwds)
>    1486
>
> TypeError: render_vertices_3d() got multiple values for keyword
> argument 'color'

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to