On Jan 5, 9:59 pm, Michael Orlitzky <[email protected]> wrote: > On 01/05/2012 09:28 PM, kcrisman wrote: > > > > >> Please, add anything I've left out. Checklists won't make a review good, > >> but they can prevent it from being too bad. > > > Hmm, maybe this should be added to the developer guide? How much of > > your checklist is in the 'reviewing patches' section, and how much > > could be added? > > At the moment, it comes from three sources: > > * What I could think up while writing it > * William's blog post > * Issues I've missed in past reviews > > There is definitely major overlap with the developer's guide, but I > really intend to use it as a checklist when reviewing patches, and there > are a few advantages the wiki has: > > * Most importantly, I'd like to be able to add new items to it easily > if I miss things in future reviews. > > * The items should be short, probably no more than one line. > > * The checklist should assume you know what you're doing, and simply > list the items rather than explain them (this is probably the same > as the last item). > > * It's nice to be able to add quick informal entries that might not be > so appropriate for the official documentation. > > Do I remember correctly that changes to the developer guide need to be > reviewed?
They are patches to devel/sage/doc, so see http://wiki.sagemath.org/ReviewChecklist ;-) -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
