On Wed, Feb 29, 2012 at 5:47 AM, Jason Grout <jason-s...@creativetrax.com> wrote: > On 2/28/12 11:19 PM, kcrisman wrote: >> >> "Needs reviewer", or >> something - that's probably not the right wording, but you get the >> point. > > > Exactly what I was going to suggest, if we are indeed going to go in the > direction of yet another layer and step before a patch gets reviewed. There > is a distinction between a patch the author feels is finished and a patch > the author knows won't work yet, and it should be easy for potential > reviewers to quickly search for the former (for example, right now they can > search for "needs review").
I strongly agree. When I've reviewed tickets I wasn't specifically asked to look at, I've always searched for "needs review." Having to manually tease out those not ready for review from those without a reviewer would be a step backwards. It's not clear what new information an additional status would be, as it's == "needs review" + "empty reviewer" (or, perhaps, just "empty reviewer"). Perhaps what needs to change is the feeling (if any) that a ticket is "done" on the part of an author once the code is posted. Renaming "needs review" to something that more strongly indicates there's more work for the author to do could help here. > If William can automate the suggestions (like it seems he is thinking), I > think it would be great to help people connect across the Sage community, > for reviewing or even for writing new code. I think it'd be great to be able to automate suggested reviewers, but the author should feel an obligation to go over the list and reach out personally to potential reviewers, which will be both more polite and more effective. Suggestions could be made the other way as well, with a "tickets you might be interested in reviewing" page. - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
