On Fri, Aug 31, 2012 at 1:39 PM, Simon King <[email protected]> wrote: > Hi Robert, > > On 2012-08-31, Robert Bradshaw <[email protected]> wrote: >> On Fri, Aug 31, 2012 at 10:04 AM, Simon King <[email protected]> wrote: >>> In addition, I don't understand why the plugin is complaining: All >>> functions introduced by my patch have a test, and I even add a test that >>> refers to the ticket (showin that some problem is fixed). So, what >>> criteria are to meet for making the plugin happy? >> >> Looking at http://patchbot.sagemath.org/log/13370/debian/lenny/sid/x86_64/... >> , I see >> >> Decreased doctests misc/cachefunc.pyx from 56 / 63 = 88% to 60 / 68 = 88% >> >> which indicates that there were formerly 7 undoctested functions in >> this file and now there are 8. > > The point is that my patch doesn't touch misc/cachefunc.pyx.
I see that you have 5 dependencies; perhaps one of them does? (It computes the diff against pristine sage-main, dependencies and all.) It doesn't try to build/run/test the union of your dependencies minus the new patches (though that's arguably a sane feature request). - Robert -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel?hl=en.
