Yep, same opinion : I think that it's ok. When I do it, it is because I think that it should not appear in the list of "tickets needing review", just in case somebody goes there to find something to review. It's not funny to do so when half of the tickets needing review are actually totally abandonned :-)
Nathann On Wednesday, February 20, 2013 5:14:21 PM UTC+1, KnS wrote: > > Thank you all for the replies. Just going through the ticket list I had > compiled that I'd go through now. > > ~KnS > > > On Wed, Feb 20, 2013 at 9:38 PM, Jeroen Demeyer > <jdem...@cage.ugent.be<javascript:> > > wrote: > >> On 2013-02-20 17:04, Kannappan Sampath wrote: >> > Hello!! >> > >> > Is it considered good manners to change the status of a (needs_review) >> > ticket to sth else (of course, other than giving (positive_review)) when >> > you are not the reviewer, but the reviewer has left some comments >> > indicating some work to be done or asking for some more information >> > about the patch? >> > >> > I am asking this because, there are a couple of tickets, which are >> > obviously not those that need_review (they either needs_work or >> > needs_info). >> >> I'd say yes. If some comment can be interpreted as needs_work, then it's >> okay to set the status to needs_work. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+...@googlegroups.com <javascript:>. >> To post to this group, send email to sage-...@googlegroups.com<javascript:> >> . >> Visit this group at http://groups.google.com/group/sage-devel?hl=en. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
