On 21 June 2013 11:26, Mathieu Guay-Paquet <[email protected]> wrote: > Hi everyone, > > Several functions and methods in Sage have mutable default arguments, > especially lists. This is generally frowned upon, at least on the Python > side (see http://effbot.org/zone/default-values.htm), since it can cause so > many subtle bugs, and there's usually no benefit to doing this instead of > using a tuple or None (with creation of the mutable argument in the function > body). I know I've have a patch rejected until I fixed this once, and I now > agree with the principle, but maybe this is not actually a widespread > policy, hence the question: > > Are there any objections to fixing this?
Not from me (and I am responsible for the last 9 items in your list), but this sort of change is likely to interfere with lots of patches currently in the system. Perhaps the best way forward would be to split this up into sections, rather than doing it all at once. For example we could deal with the elliptic curve cases in one ticket. John > > See trac ticket 14795. > > Cheers, > Mathieu Guay-Paquet > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
