Hey, (response following ping of William on IPython ML)
Looks nice I haven't looked at everything from your modifications, but I would say that it should be possible to selectively extend the templates to avoid the copy/past which should remove roughly 400 lines and some maintenance burden. Havent diffed the files with IPython 2.3 (I assume you based your work on IPython 2.2/2.3. You might also want to create your own codemirror mode to have correct syntax highlighting in the notebook (but that should be a separate patch I guess, I can point you to the right resources to do that). Most of the rest of the code is Sage internals, so I'n not super qualified to judge, but after a quick look I haven't seen anything obviously wrong. (I'm not used to track, so I still struggle like a noob, and will take longer look later.) Le lundi 6 octobre 2014 16:36:30 UTC+2, Volker Braun a écrit : > > anybody? > > > On Monday, September 29, 2014 12:48:55 PM UTC+1, Volker Braun wrote: >> >> Now would be a good time to review the IPython notebook: >> >> http://trac.sagemath.org/ticket/16996 >> >> There is clearly more to be done to make the integration perfect, and we >> could also always wait for the next IPython version. But a bird in the hand >> is worth two in the bush... >> > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
