Hi Martin, On 2015-06-15, 'Martin R' via sage-devel <[email protected]> wrote: > Since Morphism inherits from Map, this would be Map. It would be great if > you did. Could you somehow check? Might there be something on trac? > > (On the other hand, Map assumes that we can call the map, and there seems > some stuff about coercion in it, so I somehow doubt it...)
Then probably I recall wrongly. It could actually be that I was the one who said that the _codomain is "cdef Parent", arguing that maps in Sage are callable and thus domain and codomain should be Parent. Anyway, I wouldn't oppose to change it to cdef CategoryObject _codomain I don't see a problem with the fact that a __call__ method exists: If you have a domain that is not a Parent, then you will not have elements, and you would never be in the position to call it. But even IF you'd call the morphism in that case, then I think a TypeError is the correct result. How much would break with the above changes from Parent to CategoryObject? Best regards, Simon -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
