I have the following Cython design under review:
-------------------
cdef helper(x):
 ....

def A(..):
   return helper(foo)

def B(..):
   return helper(blah)

-------------------

A and B are properly documented, doctested, etc etc
The reviewer insists that helper() must be turned into pure Python function 
and
doctested on its own, while I find this not needed, as tests in A and B 
suffice.

He accuses me of using cdef just because I do not want to write doctests.
The module in question already has a number of cdef'd functions without 
doctests, written 
by the reviewer and positively reviewed by me some time ago.
When I point this out to the reviewer, I hear that these functions must be 
fast, so this is why
they are cdef'd.

Your opinions?

Thanks,
Dima

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to