Just to be clear what the disagreement is, as far as I can tell, this is not simply a call to GAP but a call to a GAP package "Grape" which is not part of Sage's standard installation of GAP.
As a compromise: can a (possibly slower) version be written as well, which does not call an optional package, with an optional argument to switch away from the default? On Wed, Jan 6, 2016 at 4:01 PM, Dima Pasechnik <dimp...@gmail.com> wrote: > tl;dr; : > On 6 January 2016 at 20:48, Nathann Cohen <nathann.co...@gmail.com> wrote: >> A ticket is in needs_review at #19661 [1], and the branch's main >> feature is a new graph constructor. I write here because of a >> disagreement Dima and I have about the code: I do not like at all that >> most of the code is a *string* that is sent to GAP for evaluation. > > There is a call to libgap.function_factory(), which contains (ahem!) GAP code > as the parameter. (That's what libgap.function_factory() is for, no?). > > That is, the essential part of the functionality is a GAP function > that is installed into libGAP > using libgap.function_factory() > The said function is then called to create a Sage object from its output. > > The reviewer objects to this style, saying that the guts of the GAP > computation must > be exposed to Sage (with finer libgap calls, I presume). Apart from > being harder to > write and debug, the style suggested by the reviewer is degrading > performance unnecessarily. > [...] >> >> [1] http://trac.sagemath.org/ticket/19661 > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
