Hi Travis, Thanks for your advice. For now, I will keep the code where it is on GitHub and SageMathCloud, and concentrate on adding documentation, examples and doctests for all the functions and methods. After that, I will revisit the problem of incorporating all r some of it into Sage proper.
As for a database of classifications of bent functions by their Cayley graphs, I think that I will first need to discuss this with the people who might use it. Topics of discussion would include the value of such a database, what should be in the database, how its contents could be generated, and where the database should be hosted. On Thursday, 11 May 2017 00:13:56 UTC+10, Travis Scrimshaw wrote: > > Hey Paul, > > 1. Is there a process to ask for a code review of this type of code > (i.e. code primarily written to support a paper)? > > It depends on what you want to do. If you want to include this code into > Sage, which is something I would recommend, then you should open a trac > ticket and upload the code as a git branch there. You will likely need to > change a few things to start the integration into Sage, but we will be > happy to help by answering questions. Another option would be to keep it as > a separate package of code (say, as a pip installable package), but then > you might not get as much exposure and need some more arm twisting to get > it reviewed. However, considering you are utilizing Sage's infrastructure, > I think the former approach is better. > > I had a very quick look through your code. It also seems like you have a > lot of things scattered across a number of files that should be groups > together into fewer files and probably into methods of a (already existing) > class. You will also want to remove your custom pickling with your Savable > class in order to not add an additional layer. The biggest thing you will > have to do is add documentation and tests to all of your functions/methods. > [...] > >> 1. Is there a process to promote this code, or a part of this code to >> Sage itself? >> Note: if this requires a complete rewrite then this could take me >> some time, as it is a one-person project conducted in my spare time as an >> Honorary Fellow of the University of Melbourne. >> >> You are basically doing it, but it can have further reach by being > included in Sage's codebase. > >> >> 1. Is there any interest in my further developing this code to >> include a database (e.g. SQL) of Cayley graph classifications? >> >> We have a number of database spkgs in Sage (see the optional spkgs), so > this could be a good option as part of including your code. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
