Hi,

Le vendredi 11 août 2017 08:12:42 UTC+2, David Roe a écrit :
>
> Note that this is changed in https://trac.sagemath.org/ticket/23592
>

This is not the same part of manifolds code: #23592 
<https://trac.sagemath.org/ticket/23592> deals with comparison of points 
(sage.manifolds.point.ManifoldPoint.__eq__), while the issue discussed here 
is related to assignment of tensor components 
(sage.tensor.modules.comp.CompWithSym.__setitem__). Since only nonzero 
components are stored, the test  
elif value == 0:
is performed in line 3263 of  src/sage/tensor/modules/comp.py
Now, as pointed by Ralf and similarly to what has been done in #23592, one 
could weaken this test to 
elif value.is_trivial_zero():
In this way, Maxima will not be called and, in addition to fixing the above 
bug, one could expect a significant speed-up.
I am going to open a ticket on this.

Eric.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to