On Thu, Jun 28, 2018 at 12:55 AM Maarten Derickx <m.derickx.stud...@gmail.com> wrote: > > Hi Victor, > > Just looked at the ticket, and without looking at the mathematical content I > see a few things that make the ticket probably not get attention from > reviewers. > > 1) The plugins of the patchbot currently show multiple problems with your > ticket: https://patchbot.sagemath.org/ticket/24542/ > 2) The ticket on trac is says your ticket is in the component: "packages: > standard". However, that label only for already very robust third party > packages like the ones mentioned on > http://www.sagemath.org/links-components.html . A first glance of your code > shows that you just modify and add .py files in the core sage library. > However just modifying .py files is not adding a third party package so you > should just file your ticket under the mathematical component that your > ticket falls under. > > Is this your first contribution to sage? > If so, do you have anyone that you personally know that has succesfully > contributed to sage in the past? Making a first succesfull contribution to > sage that also meets all the standard that your code has to satisfy without > the guidance of a more experienced sage developer is something that is really > difficult. > > Another option to make your code available instead of modifying the sage > source code is just to make a pip package like I did with my private sage > code in order to make it reusable for others: > https://github.com/koffie/mdsage . Depending what you are expecting this > might be a good choice. If your standalone package becomes succesful it can > then later still be included in sage.
+1 Victor, if you're (understandably) frustrated at the slow speed of getting your code in Sage, I believe a good approach might be to instead make your own package that depends on Sage. Then you (and anyone who already has sage, whom you would like to have install your package) can run (for example): $ sage -pip install sage-binary-relations (or whatever you want to name the package). Although there's not yet a lot of great guidance to this effect in the official Sage developer's guide, there has been some work (especially by Nicolas Thiery) on making it easier to package extension packages for Sage. Please see: https://github.com/sagemath/sage-package and see https://github.com/sagemath/sage_sample which you can fork to start your project from, and has instructions for setting everything up. Best, E > On Wednesday, 23 May 2018 00:13:25 UTC+2, Victor Porton wrote: >> >> I committed a new feature of Sage 4 months ago. It is now needs_review. Why >> is it not yet accepted? Is something wrong? Or should I just wait more? >> >> https://trac.sagemath.org/ticket/24542 > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
