Your fix looks good Reimundo. Could you open a ticket and post the
number in this thread?
Vincent
Le 29/04/2020 à 19:54, 'Reimundo Heluani' via sage-devel a écrit :
On Apr 29, Dennis Epple wrote:
Hello,
"!=" does not seem to work for permutation groups.
sage: G = SymmetricGroup(2)
sage: H = PermutationGroup([(1,2)])
sage: not G == H
False
sage: G != H
True
It seems it's in the richcmp method of PermutationGroup_generic. The
following diff fixes this particular instance, but someone may want to
do this better:
diff --git a/src/sage/groups/perm_gps/permgroup.py
b/src/sage/groups/perm_gps/permgroup.py
index 8512b01122..fd7f1d9777 100644
--- a/src/sage/groups/perm_gps/permgroup.py
+++ b/src/sage/groups/perm_gps/permgroup.py
@@ -158,7 +158,7 @@ from sage.sets.finite_enumerated_set import
FiniteEnumeratedSet
from sage.categories.all import FiniteEnumeratedSets
from sage.groups.conjugacy_classes import ConjugacyClassGAP
from sage.structure.richcmp import (richcmp_method,
- richcmp, rich_to_bool, op_EQ)
+ richcmp, rich_to_bool, op_EQ, op_NE)
def load_hap():
@@ -701,7 +701,7 @@ class PermutationGroup_generic(FiniteGroup):
gSelf = self._libgap_()
gRight = right._libgap_()
- if op == op_EQ:
+ if op in [op_EQ,op_NE]:
return gSelf._richcmp_(gRight, op)
if gSelf.IsSubgroup(gRight):
sage: G = PermutationGroup([(1,2)])
sage: H = PermutationGroup([(1,2)])
sage: not G == H
False
sage: G != H
True
sage: G = SymmetricGroup(2)
sage: H = SymmetricGroup(2)
sage: not G == H
False
sage: G != H
False
SageMath version 9.0
Python 3.7.3.
Best regards,
Dennis
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send
an email
to [1]sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
[2]https://groups.google.com/d/msgid/
sage-devel/93c5002b-5d0e-4f32-924f-4715d85f6e8b%40googlegroups.com.
References:
[1] mailto:sage-devel+unsubscr...@googlegroups.com
[2]
https://groups.google.com/d/msgid/sage-devel/93c5002b-5d0e-4f32-924f-4715d85f6e8b%40googlegroups.com?utm_medium=email&utm_source=footer
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-devel/8890e865-d5a4-486c-dcff-7059c96f2417%40gmail.com.
