As told I have cleaned the ticket and has made an experimental package and changes have been pushed to git trac and with ticket number #29336 Sir, I have already uploaded my draft for review, kindly have given some time to provide your valuable feedback, waiting to hear from you soon.
On Thu, Mar 26, 2020 at 8:23 PM David Coudert <[email protected]> wrote: > I already answered in https://trac.sagemath.org/ticket/29336 > > First, your commit > - contains files from your personal directory that should not be here like > `generic_graph (copy).py > <https://git.sagemath.org/sage.git/diff/src/sage/graphs/generic_graph%20(copy).py?id=0696be343432d57ca202d043a2536ddbb4a75b0f>`, > `graph_generators_pyx (copy).pyx`, `sample/lol.tsv > <https://git.sagemath.org/sage.git/diff/sample/lol.tsv?id=0696be343432d57ca202d043a2536ddbb4a75b0f>`, > etc. > - modifies a file that should not be touched like `digraph_generators.py`, > > => Please clean the branch first > > Second: You cannot copy/paste the code of another author like that. The > right way is to make an experimental package for sagemath with an interface. > > > Le jeudi 26 mars 2020 15:39:39 UTC+1, Suraj Modi a écrit : >> >> Ticket number 29336 >> >> On Thu, Mar 26, 2020, 7:43 PM David Coudert <[email protected]> wrote: >> >>> which ticket number ? >>> >>> Le jeudi 26 mars 2020 14:59:11 UTC+1, Suraj Modi a écrit : >>>> >>>> On Monday, March 16, 2020 at 1:43:58 PM UTC+5:30, David Coudert wrote: >>>> > First, instead of adding multiple screenshots, you could simply >>>> gather the results in an array. >>>> > >>>> > >>>> > It seems that your implementation is faster than previous algorithm. >>>> Which are the conditions of your code ? is it working for directed ? >>>> weighted ? graphs with multi edges ? loops ? etc. >>>> > >>>> > >>>> > >>>> > Le dimanche 15 mars 2020 07:43:23 UTC+1, Suraj Modi a écrit : >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > Thank you sir, >>>> > I have tested on multiple inputs even on the total of edges of graph >>>> of 10^6 >>>> > Here is the output ,sir please guide me what to do next >>>> > >>>> > >>>> > >>>> > On Sunday, March 15, 2020 at 1:05:07 AM UTC+5:30, David Coudert >>>> wrote: >>>> > You have tested only for these values ? >>>> > >>>> > >>>> > Le samedi 14 mars 2020 20:10:36 UTC+1, Suraj Modi a écrit : >>>> > Thank you, sir, for suggestions >>>> > I have run the example test cases given in the comment section of the >>>> graph generators >>>> > and here is the output sir can you please guide me what to do next >>>> > >>>> > >>>> > >>>> > >>>> > On Friday, March 13, 2020 at 8:03:32 PM UTC+5:30, David Coudert >>>> wrote: >>>> > you can test digraphs.DeBruijn(..) digraphs.GeneralizedDeBruijn(..) >>>> digraphs.ImaseItoh(...) >>>> > and also symmetric versions of undirected graphs >>>> like DiGraph(graphs.RandomBarabasiAlbert(...)) >>>> > >>>> > >>>> > Le vendredi 13 mars 2020 15:21:53 UTC+1, Suraj Modi a écrit : >>>> > Thank you, sir >>>> > can you kindly give me some edge-case test cases so that I could test >>>> them? >>>> >>>> Sir I have already uploaded my draft for review,kindly have give some >>>> time to provide your valuable feed back , waiting to hear from you soon. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sage-gsoc" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sage-gsoc/71c3c76a-e4e7-4fe7-bdbf-18a179668129%40googlegroups.com >>> <https://groups.google.com/d/msgid/sage-gsoc/71c3c76a-e4e7-4fe7-bdbf-18a179668129%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "sage-gsoc" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-gsoc/4eb7bc57-f870-4f4a-bada-540a7bb1d88c%40googlegroups.com > <https://groups.google.com/d/msgid/sage-gsoc/4eb7bc57-f870-4f4a-bada-540a7bb1d88c%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- *SURAJ KUMAR MODI* *B.TECH IN CSE* *NIT DURGAPUR* *8101384117* -- You received this message because you are subscribed to the Google Groups "sage-gsoc" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-gsoc/CAL%2BBghmH9qgCP_zWzt3SHFV7bxEfO20jGBaVuT4eNJm%3D_KnPKg%40mail.gmail.com.
