Hi, Thanks Prof.Rudi and Prof.Stefan for the suggestions. I think i found out the reason.As per my understanding, the sage runtime expects the return value of a function to be of Sage class and it should implement some necessary functions. So when i changed the return value to *BasisMatroid*(a class) from *Matroid *(which is not a class), it showed no errors.I've pushed the branch, and set the status to needs-review.
You may want to have a look and provide further suggestions,as my implementation may not be clean and the algo (which is a fairly straight-forward one) may be improved. Thanks Rajesh Veeranki Final year,B.Tech C.S.E,IIT Bombay On Sun, Feb 16, 2014 at 1:53 AM, Stefan van Zwam <[email protected]>wrote: > Hi, > > In answer to your question on where matroid union should go, maybe we need > a submenu "constructions" inside "matroids"? So we'd get > > sage: matroids.constructions.MatroidUnion(M1,M2,M3) > > As input I'd suggest allowing a list of matroids (like above) and an > iterator, as in > > sage: S = set([M1,M2,M3]) > sage: matroids.constructions.MatroidUnion(S) > > But that's just my opinion, I welcome other input. > > --Stefan. > > > On Feb 15, 2014, at 10:45 AM, Rajesh Veeranki wrote: > > > Hi, > > > > I have tried implementing the Matroid Union function, ticket 14667. > > It works fine when run as a stand alone file.But when i include it in > the matroids module,and make, and call the function, > > i get NotImplementedError: subclasses need to implement this.The > stack-trace can be found here. > > > > Here is the matroid_union.py file that i added. > > And here is the stand alone file that works. > > > > Please let me know what i'm missing, as i'm new to the dev process.Also > can you give me more test-cases to verify my implementation. > > > > Thanks, > > Rajesh Veeranki > > > > > > -- > > > > --- > > You received this message because you are subscribed to the Google > Groups "sage-matroid" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > For more options, visit https://groups.google.com/groups/opt_out. > > -- > > --- > You received this message because you are subscribed to the Google Groups > "sage-matroid" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- *Rajesh Veeranki** | Senior Undergraduate | **C.S.E** | **IIT Bombay* -- --- You received this message because you are subscribed to the Google Groups "sage-matroid" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
