Have you seen #21356 which already has positive review and is tested by Volker right now?
> On 28/08/2016, at 13:09, Vincent Delecroix <20100.delecr...@gmail.com> wrote: > > #21357 needs review > > On 27/08/16 22:02, leif wrote: >> Vincent Delecroix wrote: >>> However, running the patchbot on the same computer I got one failing >>> doctest >>> >>> Failed example: >>> G.canonical_label(certify=True) >>> Expected: >>> doctest:...: DeprecationWarning: use the option 'certificate' >>> instead of 'certify' >>> See http://trac.sagemath.org/21111 for details. >>> (Graph on 2 vertices, {'a': 0, 'b': 1}) >>> Got: >>> doctest:warning >>> ... >>> DeprecationWarning: use the option 'certificate' instead of 'certify' >>> See http://trac.sagemath.org/21111 for details. >>> (Graph on 2 vertices, {'a': 1, 'b': 0}) >> >> ... which shows that >> >> a) the test doesn't make sense (after all, it's supposed to just test >> the deprecation of "certify" I think) >> >> b) as is, the representation returned for a vertex-labeled graph isn't >> canonical... ;-) >> >> >> -leif >> >> >> P.S.: File src/sage/graphs/generic_graph.py, line 20930. >> >> >>> >>> On 27/08/16 00:11, Vincent Delecroix wrote: >>>> Builds and tests long pass on Ubuntu 14.04.5 LTS (gcc version 4.8.4). >>>> >>>> Vincent >>> >> > > -- > You received this message because you are subscribed to the Google Groups > "sage-release" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-release+unsubscr...@googlegroups.com. > To post to this group, send email to sage-release@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-release. > For more options, visit https://groups.google.com/d/optout. This email may be confidential and subject to legal privilege, it may not reflect the views of the University of Canterbury, and it is not guaranteed to be virus free. If you are not an intended recipient, please notify the sender immediately and erase all copies of the message and any attachments. Please refer to http://www.canterbury.ac.nz/emaildisclaimer for more information. -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To post to this group, send email to sage-release@googlegroups.com. Visit this group at https://groups.google.com/group/sage-release. For more options, visit https://groups.google.com/d/optout.
