On Tue, 13 Jun 2023 at 17:06, John Cremona <john.crem...@gmail.com> wrote:
> The elliptic curve failure might be a consequence of the recently merged > PR #35626 about using libpari to compute ranks and generators. > > I'll take a look to at least see if the output you get is mathematically > correct -- generators are not unique. > I was right. This curve has rank 1 and torsion (Z/2Z)^2 so if P is one generator (of infinte order) then there are 3 other, P+T for T a point of order 2. The one your are getting is one of these. So we conclude that we cannot reply on pari always returning the same generator despite random seeds etc being fixed in doctests. I don't know why that is, but if it is the case then this (and other similar) doctests will have to be written accordingly. > > John > > > On Tue, 13 Jun 2023, 17:00 Emmanuel Charpentier, < > emanuel.charpent...@gmail.com> wrote: > >> On Debian testing running on core i7 + 16 GB RAM, upgrading 10.1.beta2 to >> 10.1.beta3 and rinning ptestlong gives 3 permanent failures : >> ---------------------------------------------------------------------- >> sage -t --long --warn-long 207.1 >> --random-seed=291812591553963182024849035945523427319 >> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >> sage -t --long --warn-long 207.1 >> --random-seed=291812591553963182024849035945523427319 >> src/sage/coding/linear_code.py # 2 doctests failed sage -t --long >> --warn-long 207.1 --random-seed=291812591553963182024849035945523427319 >> src/sage/coding/code_constructions.py # 1 doctest failed >> ---------------------------------------------------------------------- >> >> The last two have been already reported a few times, and seem cosmetic. >> The first one is new and seemingly *not* cosmetic : >> charpent@zen-book-flip:/usr/local/sage-10$ sage -t --long --warn-long >> 207.1 --random-seed=291812591553963182024849035945523427319 >> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >> Running doctests with ID 2023-06-13-17-49-08-8dac2a23. Git branch: develop >> Git ref: 10.1.beta0-453-g443b7549ad Running with >> SAGE_LOCAL='/usr/local/sage-10/local' and >> SAGE_VENV='/usr/local/sage-10/local/var/lib/sage/venv-python3.11' Using >> --optional=debian,dot2tex,fricas,gap_jupyter,gap_packages,libsemigroups,msolve,pip,pysingular,sage,sage_spkg,singular_jupyter >> Features to be detected: >> 4ti2,benzene,bliss,buckygen,conway_polynomials,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_jones_numfield,database_knotinfo,dvipng,fpylll,gfan,graphviz,imagemagick,ipython,jupymake,kenzo,latte_int,lrcalc_python,lrslib,mcqd,meataxe,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pynormaliz,pyparsing,python_igraph,requests,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.gap,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modules,sage.plot,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.rings.real_mpfr,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sphinx,sympy,tdlib >> Doctesting 1 file. sage -t --long --warn-long 207.1 >> --random-seed=291812591553963182024849035945523427319 >> src/sage/schemes/elliptic_curves/ell_rational_field.py >> ********************************************************************** File >> "src/sage/schemes/elliptic_curves/ell_rational_field.py", line 2380, in >> sage.schemes.elliptic_curves.ell_rational_field.EllipticCurve_rational_field.? >> Failed example: E.gens(use_database=False, algorithm="pari",pari_effort=4) >> Expected: [(611429153205013185025/9492121848205441 : >> 15118836457596902442737698070880/924793900700594415341761 : 1)] Got: >> [(-38749202011873484470143/306317326339867638016 : >> 678721624672968530804232808604865/5361142413550167706041194328064 : 1)] >> ********************************************************************** 1 >> item had failures: 1 of 100 in >> sage.schemes.elliptic_curves.ell_rational_field.EllipticCurve_rational_field.? >> [896 tests, 1 failure, 241.41 s] >> ---------------------------------------------------------------------- sage >> -t --long --warn-long 207.1 >> --random-seed=291812591553963182024849035945523427319 >> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >> ---------------------------------------------------------------------- >> Total time for all tests: 251.7 seconds cpu time: 227.0 seconds cumulative >> wall time: 241.4 seconds Features detected for doctesting: >> sage.rings.finite_rings,sage.rings.number_field >> >> HTH, >> Le dimanche 11 juin 2023 à 13:14:49 UTC+2, Volker Braun a écrit : >> >>> As always, you can get the latest beta version from the "develop" git >>> branch. Alternatively, the self-contained source tarball is at >>> http://www.sagemath.org/download-latest.html >>> >>> 443b7549ad3 (tag: 10.1.beta3, github/develop) Updated SageMath version >>> to 10.1.beta3 >>> 464d3d20aaa gh-35738: configure: Remove stray `stdin.info` file created >>> in test >>> d27b19a4efc gh-35737: build/pkgs/maxima: Fix parallel build >>> 202ccd7ea08 gh-35733: more uses of yield from >>> aba52d4c06a gh-35731: build/pkgs/pyflakes: Remove >>> 5b446283d86 gh-35723: some pep8 cleanup in rigged-configurations >>> e90d6be7a5c gh-35722: cython-lint for imports in libs/ >>> 9c83f604a46 gh-35721: cython-lint for imports in rings (mostly in padics) >>> 5c9ee290848 gh-35720: fix the linter and add more checks >>> 6d1cb7e3323 gh-35718: `sage.graphs`: More modularization >>> a2e4cab86c8 gh-35714: provide matrix_symbolic_sparse class >>> 41aa6c290de gh-35713: update symengine(_py) to versions 0.10.0 and 0.10.1 >>> acac1e60e63 gh-35712: fix pep8 E251 in rings/ >>> 34b4234573c gh-35711: fix all pep8 E251 in combinat >>> 0a929ff9da9 gh-35710: fix pep8 E251 in categories, coding, crypto, logic >>> 6a142317110 gh-35709: some cython-linting in quadratic forms >>> d7bb52abf83 gh-35702: GAP: switch some code to use official libgap APIs >>> afc9232bff4 gh-35692: ⬆️ Bump myrotvorets/set-commit-status-action from >>> 1.1.6 to 1.1.7 >>> 6ca634ae1c0 gh-35671: Upgrade networkx to 3.1, igraph/python_igraph to >>> 0.10.4 >>> 7e0eb1c9219 gh-35666: remove obsolete .zenodo.json* files, update >>> CITATION.cff to fix zenodo/DOI >>> 86d2be056bf gh-35626: Update the rank function of elliptic curves to >>> use ellrank in pari >>> fe931a790a8 gh-35614: allow non-minimal equation for padic heights >>> 5343f2e7ea9 gh-35494: avoid computation of Conway polynomials when >>> comparing elliptic-curve morphisms >>> 2f426a11f4c (tag: 10.1.beta2) Updated SageMath version to 10.1.beta2 >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-release" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-release+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-release/774ed98e-96e3-44bf-b1ad-fe5259d90cb8n%40googlegroups.com >> <https://groups.google.com/d/msgid/sage-release/774ed98e-96e3-44bf-b1ad-fe5259d90cb8n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-release/CAD0p0K5S9HCoR--2V2t_GusuGeoDeWmQSJsr%2BSP_DDiXwa37Ng%40mail.gmail.com.
