On 29 sep, 20:28, Burcin Erocal <bur...@erocal.org> wrote: > On Wed, 29 Sep 2010 09:48:25 -0700 (PDT) > > Jean-Pierre Flori <jpfl...@gmail.com> wrote: > > Maybe it is a good thing to keep the same order as ginac internally > > and your more usual ordering for printing. > > It is good to keep the ginac ordering internally. The user friendly > ordering is more expensive so it slows down computations, even when > you don't print intermediate expressions. My bad, I didn't read your previous post correctly, I thought that patch reverted the change you made in the ordering, but in fact it put these changes in separate functions and use them only for printing... That is why I tried to fix the bug in the code without your patch... So I guess I should work WITH the patch ! > > > However if you'd better not duplicate code, I can look at the "- > > x^2+x^2" part of bug #9046. > > Now I may understand a big enough part of pynac code to do that. > > That's right. You're one of the few people who spent so much time > staring at pynac code. :) > > > But if you'd better use the above patch, that won't be necessary. > > I would like to replace the orders completely. I wanted to attack > this problem for a long time. Now that we started, we might as > well finish. :) So once more I'm confused.. What do you mean by replace the orders completely ? Having separate functions for internal use and printing as with what your patch does ? Or continue from the code before the above patch and make everything back consistent so just one set of functions is present, even if it can finally produce slower code ? I guess that is because I was already confused before and what I said may have seemed obscure..
> > Can you help put the patch in usable shape? At the moment the ordering > it defines is completely different from the one we use in Sage. This > must be because I changed some signs while I was copying code. I'll help with pleasure. Just want to be sure to take the right direction ! > > If you can make the ordering consistent, I can fix the other relevant > places (op(), etc.). > > Thanks. > > Burcin Cheers, -- To post to this group, send email to sage-support@googlegroups.com To unsubscribe from this group, send email to sage-support+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-support URL: http://www.sagemath.org
