On Mon, 23 Sep 2002, Andrew Bartlett wrote:

> [EMAIL PROTECTED] wrote:
> > 
> > Date:   Sun Sep 22 16:22:48 2002
> > Author: sharpe
> > 
> > Update of /data/cvs/samba/source/libsmb
> > In directory dp.samba.org:/tmp/cvs-serv10180/libsmb
> > 
> > Modified Files:
> >         clientgen.c
> > Log Message:
> > 
> > Small, long overdue, fix for libsmbclient.
> 
> Why?  I think I already fixed that, by calling send_keepalive(cli->fd)
> inline in the keepalive fn.  

OK, having looked at it, I notice that cli_send_keepalive is perhaps not 
needed, but it does more cleanup, and I am disturbed by the comments that 
suggest smbc_check_server is perhaps used by the external cache stuff.

That seems to create more dependencies that we need, and it might be 
better to move check_server into clientgen or something like that and call 
it cli_check_server?

Regards
-----
Richard Sharpe, [EMAIL PROTECTED], [EMAIL PROTECTED], 
[EMAIL PROTECTED]

Reply via email to