Date: Wed Sep 25 06:03:20 2002
Author: tpot
Update of /data/cvs/samba/source/rpc_parse
In directory dp.samba.org:/tmp/cvs-serv22160
Modified Files:
Tag: APPLIANCE_HEAD
parse_spoolss.c
Log Message:
A PRINTER_INFO_2 doesn't necessarily contain a security descriptor.
For example, Windows NT/2K doesn't return a secdesc for a enumprinters
level2 but Samba currently does. Fix by checking the offset is
non-zero before trying to unmarshall a security descriptor.
(The reldevmode and relsecdesc stuff is a bit of a mess - the offsets
for these two guys should not be unmarshalled inside the
smb_io_rel{secdesc|devmode} functions but rather in the
smb_io_printer_info_2 function. This would get rid of the
prs_uint32(dummy_value) rubbish that makes this function confusing.)
Jerry/Jeremy, I've tested this change marshalling and unmarshalling
PRINTER_INFO_2 structures and it still works OK.
Revisions:
parse_spoolss.c 1.81.2.56 => 1.81.2.57
http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_spoolss.c?r1=1.81.2.56&r2=1.81.2.57
