On Fri, Nov 08, 2002 at 09:39:45PM +1100, Andrew Bartlett wrote: > On Fri, 2002-11-08 at 21:37, Jelmer Vernooij wrote: > > On Fri, Nov 08, 2002 at 09:24:43PM +1100, Andrew Bartlett wrote: > > > On Fri, 2002-11-08 at 08:39, [EMAIL PROTECTED] wrote: > > > > > > > > Date: Thu Nov 7 21:39:51 2002 > > > > Author: jelmer > > > > > > > > Update of /home/cvs/samba/source/smbd > > > > In directory dp.samba.org:/tmp/cvs-serv25030/smbd > > > > > > > > Modified Files: > > > > server.c > > > > Log Message: > > > > > > > > Make append_log work again > > > This looks really ugly - is there any sane reason why we would ever want > > > to open the log files O_TRUNCATE? Is that support still in debug just > > > because nmbd has the command line option, or does some part of the code > > > really use it? > > The O_TRUNCATE was there before I moved in popt - even uglier as it is now. > > Unless we remove append-log from nmbd, we can't throw out O_TRUNCATE. > That is my proposal. If it never worked in smbd, I don't see a great > need for nmbd to support it. I agree. I wouldn't know why anyone would want truncating anyway, but if we would support it, it should be a lp_() parameter.
Anyone against this? jelmer