Date: Fri Jan 17 04:58:43 2003 Author: tridge Update of /home/cvs/samba/source/rpc_client In directory dp.samba.org:/tmp/cvs-serv3428/rpc_client
Modified Files: cli_srvsvc.c Log Message: This removes the 3rd argument from init_unistr2(). There were 240 calls to init_unistr2() in the code and every one of them got the 3rd argument incorrect, so I thought it best just to remove the argument. The incorrect usage was caused by callers using strlen() to determine the length of the string. The 3rd argument to init_unistr2() was supposed to be the character length, not the byte length of the string, so for non-english this could come out wrong. I also removed the bogus 'always allocate at least 256 bytes' hack. There may be some code that relies on this, but if there is then the code is broken and needs fixing. Revisions: cli_srvsvc.c 1.25 => 1.26 http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_client/cli_srvsvc.c?r1=1.25&r2=1.26