Date: Mon Jun 16 02:22:52 2003 Author: tridge Update of /home/cvs/samba/source/lib In directory dp.samba.org:/tmp/cvs-serv31784
Modified Files: Tag: SAMBA_3_0 charcnv.c Log Message: reverted locale patch put in by jht (originally from vorlon). There are lots of things wrong with this patch, including: 1) it overrides a user chosen configuration option 2) it adds lots of complexity inside a loop when a tiny piece of code outside the loop would do the same thing 3) it does no error checking, and is sure to crash on some systems If you want this functionality then try something like this at the end of charset_name(): #ifdef HAVE_NL_LANGINFO if (strcasecmp(ret, "LOCALE") == 0) { const char *ln = nl_langinfo(CODESET); if (ln) { DEBUG(5,("Substituting charset '%s' for LOCALE\n", ln)); return ln; } } #endif then users can set 'display charset = LOCALE' to get the locale based charset. You could even make that the default for systems that have nl_langinfo(). Revisions: charcnv.c 1.55.2.25 => 1.55.2.26 http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/charcnv.c.diff?r1=1.55.2.25&r2=1.55.2.26