Date: Wed Feb 25 22:01:02 2004 Author: abartlet Update of /home/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv23162/passdb
Modified Files: Tag: SAMBA_3_0 machine_sid.c pdb_ldap.c Log Message: I *hate* global variables... OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett Revisions: machine_sid.c 1.9.2.7 => 1.9.2.8 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/machine_sid.c.diff?r1=1.9.2.7&r2=1.9.2.8 pdb_ldap.c 1.28.2.103 => 1.28.2.104 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/pdb_ldap.c.diff?r1=1.28.2.103&r2=1.28.2.104