Author: jra
Date: 2006-02-17 15:51:27 +0000 (Fri, 17 Feb 2006)
New Revision: 13543

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13543

Log:
Don't reuse a pointer we just freed (Doh!).
Jeremy.

Modified:
   trunk/source/passdb/secrets.c


Changeset:
Modified: trunk/source/passdb/secrets.c
===================================================================
--- trunk/source/passdb/secrets.c       2006-02-17 15:51:25 UTC (rev 13542)
+++ trunk/source/passdb/secrets.c       2006-02-17 15:51:27 UTC (rev 13543)
@@ -1051,6 +1051,8 @@
                                &pdc->domain);
 
        if (ret == -1 || l1 != 8 || l2 != 8 || l3 != 8 || l4 != 16 || l5 != 16) 
{
+               /* Bad record - delete it. */
+               tdb_delete_bystring(tdb_sc, keystr);
                talloc_free(keystr);
                talloc_free(pdc);
                SAFE_FREE(pseed_chal);
@@ -1059,8 +1061,6 @@
                SAFE_FREE(psess_key);
                SAFE_FREE(pmach_pw);
                SAFE_FREE(value.dptr);
-               /* Bad record - delete it. */
-               tdb_delete_bystring(tdb_sc, keystr);
                return False;
        }
 

Reply via email to