Author: vlendec Date: 2006-03-12 18:01:36 +0000 (Sun, 12 Mar 2006) New Revision: 14249
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14249 Log: We've dereferenced the_acl before, no point in checking. Fix Coverity bug # 128. Volker Modified: branches/SAMBA_3_0/source/lib/secdesc.c trunk/source/lib/secdesc.c Changeset: Modified: branches/SAMBA_3_0/source/lib/secdesc.c =================================================================== --- branches/SAMBA_3_0/source/lib/secdesc.c 2006-03-12 17:57:05 UTC (rev 14248) +++ branches/SAMBA_3_0/source/lib/secdesc.c 2006-03-12 18:01:36 UTC (rev 14249) @@ -433,7 +433,7 @@ if (!(new_ace_list = TALLOC_ARRAY(ctx, SEC_ACE, the_acl->num_aces))) return NULL; - for (i = 0; the_acl && i < the_acl->num_aces; i++) { + for (i = 0; i < the_acl->num_aces; i++) { SEC_ACE *ace = &the_acl->ace[i]; SEC_ACE *new_ace = &new_ace_list[new_ace_list_ndx]; uint8 new_flags = 0; Modified: trunk/source/lib/secdesc.c =================================================================== --- trunk/source/lib/secdesc.c 2006-03-12 17:57:05 UTC (rev 14248) +++ trunk/source/lib/secdesc.c 2006-03-12 18:01:36 UTC (rev 14249) @@ -433,7 +433,7 @@ if (!(new_ace_list = TALLOC_ARRAY(ctx, SEC_ACE, the_acl->num_aces))) return NULL; - for (i = 0; the_acl && i < the_acl->num_aces; i++) { + for (i = 0; i < the_acl->num_aces; i++) { SEC_ACE *ace = &the_acl->ace[i]; SEC_ACE *new_ace = &new_ace_list[new_ace_list_ndx]; uint8 new_flags = 0;