Author: jra Date: 2006-12-09 02:58:18 +0000 (Sat, 09 Dec 2006) New Revision: 20090
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20090 Log: Fix a class of bugs found by James Peach. Ensure we never mix malloc and talloc'ed contexts in the add_XX_to_array() and add_XX_to_array_unique() calls. Ensure that these calls always return False on out of memory, True otherwise and always check them. Ensure that the relevent parts of the conn struct and the nt_user_tokens are TALLOC_DESTROYED not SAFE_FREE'd. James - this should fix your crash bug in both branches. Jeremy. Modified: branches/SAMBA_3_0/source/auth/auth_util.c branches/SAMBA_3_0/source/groupdb/mapping.c branches/SAMBA_3_0/source/groupdb/mapping_ldb.c branches/SAMBA_3_0/source/groupdb/mapping_tdb.c branches/SAMBA_3_0/source/lib/privileges.c branches/SAMBA_3_0/source/lib/system_smbd.c branches/SAMBA_3_0/source/lib/util.c branches/SAMBA_3_0/source/lib/util_sid.c branches/SAMBA_3_0/source/lib/util_str.c branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c branches/SAMBA_3_0/source/nsswitch/winbindd_async.c branches/SAMBA_3_0/source/nsswitch/winbindd_cm.c branches/SAMBA_3_0/source/nsswitch/winbindd_group.c branches/SAMBA_3_0/source/nsswitch/winbindd_rpc.c branches/SAMBA_3_0/source/nsswitch/winbindd_util.c branches/SAMBA_3_0/source/passdb/pdb_interface.c branches/SAMBA_3_0/source/passdb/pdb_ldap.c branches/SAMBA_3_0/source/rpcclient/cmd_samr.c branches/SAMBA_3_0/source/smbd/conn.c branches/SAMBA_3_0/source/smbd/service.c branches/SAMBA_3_0_24/source/auth/auth_util.c branches/SAMBA_3_0_24/source/groupdb/mapping.c branches/SAMBA_3_0_24/source/groupdb/mapping_ldb.c branches/SAMBA_3_0_24/source/groupdb/mapping_tdb.c branches/SAMBA_3_0_24/source/lib/privileges.c branches/SAMBA_3_0_24/source/lib/system_smbd.c branches/SAMBA_3_0_24/source/lib/util.c branches/SAMBA_3_0_24/source/lib/util_sid.c branches/SAMBA_3_0_24/source/lib/util_str.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_ads.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_async.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_cm.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_group.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_rpc.c branches/SAMBA_3_0_24/source/nsswitch/winbindd_util.c branches/SAMBA_3_0_24/source/passdb/pdb_interface.c branches/SAMBA_3_0_24/source/passdb/pdb_ldap.c branches/SAMBA_3_0_24/source/rpcclient/cmd_samr.c branches/SAMBA_3_0_24/source/smbd/conn.c branches/SAMBA_3_0_24/source/smbd/service.c Changeset: Sorry, the patch is too large (2089 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20090