Author: vlendec
Date: 2007-02-09 23:14:23 +0000 (Fri, 09 Feb 2007)
New Revision: 21265

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21265

Log:
Fix some valgrind errors -- not in 3_0
Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c        2007-02-09 
21:25:22 UTC (rev 21264)
+++ branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c        2007-02-09 
23:14:23 UTC (rev 21265)
@@ -80,8 +80,16 @@
                fenum->info[i].fid = (uint32)((procid_to_pid(&prec.pid)<<16) & 
prec.pnum);
                fenum->info[i].permissions = (FILE_READ_DATA|FILE_WRITE_DATA);
                fenum->info[i].num_locks = 0;
-               fenum->info[i].user = uidtoname( prec.uid );
-               fenum->info[i].path = fullpath;
+               if (!(fenum->info[i].user = talloc_strdup(
+                             fenum->ctx, uidtoname(prec.uid)))) {
+                       /* There's not much we can do here. */
+                       fenum->info[i].user = "";
+               }
+               if (!(fenum->info[i].path = talloc_strdup(
+                             fenum->ctx, fullpath))) {
+                       /* There's not much we can do here. */
+                       fenum->info[i].path = "";
+               }
                        
                fenum->count++;
        }
@@ -172,8 +180,16 @@
                fenum->info[i].fid = e->share_file_id;
                fenum->info[i].permissions = permissions;
                fenum->info[i].num_locks = num_locks;
-               fenum->info[i].user = uidtoname(e->uid);
-               fenum->info[i].path = fullpath;
+               if (!(fenum->info[i].user = talloc_strdup(
+                             fenum->ctx, uidtoname(e->uid)))) {
+                       /* There's not much we can do here. */
+                       fenum->info[i].user = "";
+               }
+               if (!(fenum->info[i].path = talloc_strdup(
+                             fenum->ctx, fullpath))) {
+                       /* There's not much we can do here. */
+                       fenum->info[i].path = "";
+               }
                        
                fenum->count++;
        }
@@ -863,8 +879,14 @@
                num_files = net_count_files(pw->pw_uid, 
session_list[*snum].pid);
                guest = strequal( session_list[*snum].username, 
lp_guestaccount() );
                                        
-               ss1->array[num_entries].client = 
session_list[*snum].remote_machine;
-               ss1->array[num_entries].user = session_list[*snum].username; 
+               if (!(ss1->array[num_entries].client = talloc_strdup(
+                             ss1->array, session_list[*snum].remote_machine))) 
{
+                       ss1->array[num_entries].client = "";
+               }
+               if (!(ss1->array[num_entries].user = talloc_strdup(
+                             ss1->array, session_list[*snum].username))) {
+                       ss1->array[num_entries].user = "";
+               }
                ss1->array[num_entries].num_open = num_files;
                ss1->array[num_entries].time = connect_time;
                ss1->array[num_entries].idle_time = 0;

Reply via email to