-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan (metze) Metzmacher schrieb: > [EMAIL PROTECTED] schrieb: >> "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]> writes: > >>> seems that revision 22772 wasn't merged into all branches... >>> http://websvn.samba.org/cgi-bin/viewcvs.cgi?rev=22772&view=rev >> Sorry, I think I merged it to all of the Samba3 branches, but it didn't >> occur to me that the same code was used in Samba4. > >>> maybe we should better move this to samba3 instead of libreplace... >>> as libreplace will not provide replacements for readahead(). >> That change should be merged into libreplace in Samba4. The problem it >> was intended to solve -- an existing readahead() function but no header >> that declares it -- would exist just as much in Samba4 as in Samba3 >> (even if nothing in Samba4 currently uses readahead). Please go ahead >> and merge that in with the current work. (There's also a configure test >> that was added in the same patch.) > > Hi Derell, > > I know of the initial problem. > But as the test for readahead function is in configure.in in samba3 > the test for the prototype should also be there, as it really only > belongs to samba3.
and we do exactly this for a lot of other functions in samba3's configure.in and include/includes.h... metze -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFGVY0Tm70gjA5TCD8RAtFtAKCjsg6TfphyF1b/zHYb7RO0YxTvswCgttCe rHd46RlFO0Ymp6QlM/Zvfsk= =4nOo -----END PGP SIGNATURE-----