Author: jra Date: 2007-08-17 01:55:58 +0000 (Fri, 17 Aug 2007) New Revision: 24501
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24501 Log: Added bcc test for reply_tcon & removed Vl's comment :-). Jeremy. Modified: branches/SAMBA_3_2/source/smbd/reply.c Changeset: Modified: branches/SAMBA_3_2/source/smbd/reply.c =================================================================== --- branches/SAMBA_3_2/source/smbd/reply.c 2007-08-16 23:53:51 UTC (rev 24500) +++ branches/SAMBA_3_2/source/smbd/reply.c 2007-08-17 01:55:58 UTC (rev 24501) @@ -442,12 +442,11 @@ START_PROFILE(SMBtcon); - /******************************************************************** - * Warning! I'm not sure that the inbuf length check is actually - * correct here. -- vl - * - * Jeremy, please check and remove this comment :-) - ********************************************************************/ + if (smb_buflen(req->inbuf) < 4) { + reply_nterror(req, NT_STATUS_INVALID_PARAMETER); + END_PROFILE(SMBtcon); + return; + } p = smb_buf(req->inbuf)+1; p += srvstr_pull_buf_talloc(req, req->inbuf, req->flags2,
