On Tue, Aug 28, 2007 at 12:40:03PM +0000, [EMAIL PROTECTED] wrote: > Author: gd > Date: 2007-08-28 12:40:01 +0000 (Tue, 28 Aug 2007) > New Revision: 24733 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24733 > > Log: > Add support for storing DATA_BLOBs in gencache.tdb (including torturetest). > > Mimir, please have a look. DATA_BLOBs will now just show up as "DATA_BLOB" > values with "net cache list".
Looks fine to me. One aesthetic note - couldn't this: > + again: > + len = 0; > + > + len += tdb_pack(buf+len, buflen-len, "fB", > + valstr, > + blob->length, blob->data); > + > + if (len == -1) { > + goto out; > + } > + > + if (buflen < len) { > + SAFE_FREE(buf); > + buf = SMB_MALLOC_ARRAY(unsigned char, len); > + if (!buf) { > + goto out; > + } > + buflen = len; > + goto again; > + } be implemented as a loop ? cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
signature.asc
Description: Digital signature