The branch, v3-2-test has been updated via 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7 (commit) via a86849e4f9512b680f26010c297cec14251dafdd (commit) from 5b8ca7ebdef5d385420c89af246c2dae737c5717 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log ----------------------------------------------------------------- commit 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7 Author: Volker Lendecke <[EMAIL PROTECTED]> Date: Thu Nov 1 17:42:35 2007 +0100 Remove unnecessary code SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure commit a86849e4f9512b680f26010c297cec14251dafdd Author: Volker Lendecke <[EMAIL PROTECTED]> Date: Tue Oct 30 22:58:09 2007 +0100 Fix a debug message ----------------------------------------------------------------------- Summary of changes: source/lib/util_str.c | 7 +------ source/smbd/trans2.c | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/util_str.c b/source/lib/util_str.c index 1f3aab3..6458ae3 100644 --- a/source/lib/util_str.c +++ b/source/lib/util_str.c @@ -411,13 +411,8 @@ char *strupper_static(const char *s) { static char *str = NULL; - if (str) { - SAFE_FREE(str); - } + SAFE_FREE(str); str = SMB_STRDUP(s); - if (!str) { - return CONST_DISCARD(char *,s); - } strupper_m(str); return str; } diff --git a/source/smbd/trans2.c b/source/smbd/trans2.c index dfd926a..3abc0d0 100644 --- a/source/smbd/trans2.c +++ b/source/smbd/trans2.c @@ -144,7 +144,7 @@ static bool get_ea_value(TALLOC_CTX *mem_ctx, connection_struct *conn, files_str return False; } - DEBUG(10,("get_ea_value: EA %s is of length %u: ", ea_name, (unsigned int)sizeret)); + DEBUG(10,("get_ea_value: EA %s is of length %u\n", ea_name, (unsigned int)sizeret)); dump_data(10, (uint8 *)val, sizeret); pea->flags = 0; -- Samba Shared Repository