The branch, master has been updated via 9b3cce096ceca8b7d72456cbc6f0a725ad55d46c (commit) via 8eb562a81db03bac3e4bb469eaa45e0969be924e (commit) from de7f0a70c8293f1b87f9c821f16fd3c6f7b184b7 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 9b3cce096ceca8b7d72456cbc6f0a725ad55d46c Author: Volker Lendecke <v...@samba.org> Date: Wed Feb 4 18:10:28 2009 +0100 Fix a valgrind error: rpc_bind talloc_move()s the auth struct commit 8eb562a81db03bac3e4bb469eaa45e0969be924e Author: Volker Lendecke <v...@samba.org> Date: Wed Feb 4 18:09:48 2009 +0100 Ensure null termination of the password in mymachinepw, remove a debug ----------------------------------------------------------------------- Summary of changes: source3/auth/auth_netlogond.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/auth/auth_netlogond.c b/source3/auth/auth_netlogond.c index a57f3b7..c39dd8c 100644 --- a/source3/auth/auth_netlogond.c +++ b/source3/auth/auth_netlogond.c @@ -134,8 +134,6 @@ static char *mymachinepw(TALLOC_CTX *mem_ctx) return NULL; } - pwd[sizeof(pwd)-1] = '\0'; - nread = read(fd, pwd, sizeof(pwd)-1); close(fd); @@ -144,7 +142,7 @@ static char *mymachinepw(TALLOC_CTX *mem_ctx) return NULL; } - DEBUG(0, ("pwd: %d [%s]\n", (int)nread, pwd)); + pwd[nread] = '\0'; if (pwd[nread-1] == '\n') { pwd[nread-1] = '\0'; @@ -238,8 +236,6 @@ static NTSTATUS check_netlogond_security(const struct auth_context *auth_context goto done; } - TALLOC_FREE(auth); - plaintext_machinepw = mymachinepw(talloc_tos()); if (plaintext_machinepw == NULL) { status = NT_STATUS_NO_MEMORY; -- Samba Shared Repository