Steven Danneman schrieb: >> Yes, please make sure you use torture_comment() instead of printf() and >> all torture_assert* functions instead of just returning false in a >> test. Then make test reports them as failures instead of errors and >> it's easy to mark them as known failures. This makes sure that the >> server doesn't crash when the test runs against it. >> >> metze > > Excellent, thanks Metze. Do we have any kind of document that describes best > practices for writing torture tests? If not I can start a wiki page.
That would be great. > Thus, far I have mostly copied style from other tests, but obviously there is > a mix of several different approaches added over the years. Yes, there's a lot of old stuff there: I started to clean it up for some tests... see 4ab243bcabefdcc044c6d517bb4d0e628227d5ac. In the end I'd like to have a #define printf __donnot_use_printf__ in lib/torture/torture.h, but he have a long way to go... metze
signature.asc
Description: OpenPGP digital signature
